localhost is also a secure origin by browsers#309
Open
segevfiner wants to merge 2 commits into
Open
Conversation
|
hey @segevfiner , are you planning to continue on this one? |
Author
|
Need to merge/rebase and see if I can figure out the tests bit. I don't remember what didn't work for me with the tests when I originally tried doing this. |
Also partitioned cookies are only allowed with secure, so in `secure: 'auto'` also set partitioned to false
segevfiner
force-pushed
the
localhost-secure
branch
from
4304529 to
37e5576
Compare
segevfiner
commented
Dec 2, 2025
segevfiner
left a comment
segevfiner
left a comment
Author
There was a problem hiding this comment.
Tried to fix that tests. Seems there was an implicit assumption about localhost being insecure in some of the tests, so I tried to work around that.
Eomm
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also partitioned cookies are only allowed with secure, so in
secure: 'auto'also set partitioned to falseChecklist
npm run test && npm run benchmark --if-presentand the Code of conduct